Conversation
…OKEN is set (#14) Co-authored-by: Automaker <automaker@localhost>
…ersistence de (#15) Co-authored-by: Automaker <automaker@localhost>
…_skill_index (#17) Co-authored-by: Automaker <automaker@localhost>
Addresses bug #3 from v0.2.0 smoke test: MemoryMiddleware was silently skipped when knowledge: false (the default config), so session memory never worked out of the box. - graph/agent.py: drop `and knowledge_store` from activation guard — memory middleware now activates whenever memory: true, regardless of knowledge store - graph/middleware/memory.py: knowledge_store is now optional (default None); guard knowledge-extraction block when store is None; add standalone prior_sessions injection via before_model when running without KnowledgeMiddleware (no double-injection: only fires when self._store is None) Co-authored-by: Ava <ava@protolabs.ai> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (9)
WalkthroughThis PR extends the middleware stack to support optional knowledge stores, implements session-based memory persistence with prior session injection into prompts, adds conditional security scheme generation based on environment configuration, and enhances test infrastructure with import path resolution and new integration/unit tests. Changes
Sequence Diagram(s)sequenceDiagram
participant Agent as Agent Execution
participant MM as MemoryMiddleware
participant State as state/messages
participant FS as Session Storage
Agent->>MM: before_model(state, runtime)
MM->>FS: _load_prior_sessions()
FS-->>MM: prior_sessions XML
MM->>State: Inject SystemMessage with<br/>prior_sessions block
State-->>Agent: Updated messages
Agent->>Agent: Process with model
Agent->>MM: after_agent(state, runtime)
MM->>MM: Detect terminal turn<br/>(last msg = AIMessage,<br/>no tool_calls)
MM->>FS: _persist_session(state, trace_id)
FS-->>MM: Session stored
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~28 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promoting 4 bug fixes from v0.2.0 smoke testing:
Post-merge
prepare-release.ymlwill auto-bump to v0.2.1.Merge strategy
Use merge commit (not squash) per branch-strategy.md.
Summary by CodeRabbit
New Features
Tests