Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (8)
WalkthroughThis PR adds a credential redaction system to the middleware layer. A new redaction module detects and replaces sensitive data (API keys, bearer tokens, environment variables) with Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redact credentials from audit.jsonl entries and Langfuse spans.
Problem
audit.pycaptures tool call args and results verbatim. Hermes Agent v0.4 had a bug where browser credentials leaked into Telegram chat via progress output — same class of bug. protoAgent'sAuditMiddlewareserializes arbitrary tool I/O; if a tool returns an API key in its payload it lands inaudit.jsonland in the Langfuse trace.Approach
graph/middleware/redaction.pywith aredact()helperRecovered automatically by Automaker post-agent hook
Summary by CodeRabbit
Release Notes
New Features
Tests