Adopt upstream PR #2973: Fix dynamicFilter parsing in tables

[protobi-pieter]

Summary

Adopt upstream PR exceljs#2973 to fix parsing error when loading Excel files with dynamic filters in tables.

Currently, ExcelJS throws "Unexpected xml node in parseOpen" exception when encountering <dynamicFilter> nodes in table definitions. This fix prevents the exception by ignoring these unsupported nodes during parsing.

Upstream PR

• PR: Fix parsing error for dynamicFilter nodes in Excel tables exceljs/exceljs#2973
• Author: @johnnyoshika (Johnny Oshika)
• Created: 2025-09-22
• Status: Open in upstream
• Related Issue: [BUG] Error parsing dynamicFilter in Excel table: "Unexpected xml node in parseOpen" exceljs/exceljs#2972

Changes

File modified:

• lib/xlsx/xform/table/filter-column-xform.js - Handle dynamicFilter nodes (3 lines)

Total: 3 additions, 0 deletions

Bug Description

When reading Excel files that contain tables with dynamic filters (e.g., date filters, top 10 filters), ExcelJS throws an exception and fails to load the file.

Current behavior:

• Throws "Unexpected xml node in parseOpen" when encountering <dynamicFilter> nodes
• Fails to load Excel files with dynamic table filters

Fixed behavior:

• Silently ignores <dynamicFilter> nodes during parsing
• Successfully loads Excel files with dynamic filters
• No attempt to preserve or recreate dynamic filters (just prevents crashes)

Value Proposition

• Low Risk - Simple 3-line addition to handle unsupported node type
• Bug Fix - Prevents crashes when reading certain Excel files
• Robustness - Improves compatibility with Excel files created by other tools

Testing Plan

• Apply changes from upstream PR
• Run existing test suite
• Verify files with dynamic filters load without errors

Implementation Notes

This PR doesn't add full dynamic filter support - it only prevents the exception. Dynamic filters will be ignored when reading and won't be preserved when writing.

[protobi-pieter]

✅ Complete

This issue was successfully resolved in commit daa210b on November 7, 2025.

Changes Applied

The fix from upstream PR #2973 was applied to lib/xlsx/xform/table/filter-column-xform.js:

Added:

case 'dynamicFilter':
  // Ignore dynamicFilter nodes - we don't need to preserve them for reading
  return true;

This prevents the "Unexpected xml node in parseOpen" exception when loading Excel files that contain tables with dynamic filters (e.g., date filters, top 10 filters).

What This Fixes

Before: ExcelJS would crash with an exception when encountering <dynamicFilter> nodes in table definitions, failing to load the entire file.

After: ExcelJS silently ignores <dynamicFilter> nodes during parsing, successfully loading files with dynamic filters.

Note: This fix doesn't add full dynamic filter support - it only prevents crashes. Dynamic filters will be ignored when reading and won't be preserved when writing back.

Testing

• ✅ All existing tests pass
• ✅ Code merged to master branch
• ✅ Pushed to remote repository
• ✅ Files with dynamic filters now load without errors

Checklist Status

• Apply changes from upstream PR
• Run existing test suite
• Verify files with dynamic filters load without errors

This issue can now be closed.

[johnnyoshika]

Thanks for merging my PR. Any idea when the update will be released?