Add unit tests for data bar conditional formatting defaults (#3015)#36
Merged
protobi-pieter merged 1 commit intomasterfrom Jan 26, 2026
Merged
Add unit tests for data bar conditional formatting defaults (#3015)#36protobi-pieter merged 1 commit intomasterfrom
protobi-pieter merged 1 commit intomasterfrom
Conversation
Add tests to verify the fix for issue exceljs#3015 works correctly: - Unit test: verifies databar-ext-xform renders default cfvo array when not specified - Integration test: verifies end-to-end data bar creation with minimal options Tests ensure data bars can be created with just type and priority, without requiring manual specification of cfvo array or color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the data bar conditional formatting fix in PR #34.
Tests Added
Unit test (spec/unit/xlsx/xform/sheet/cf-ext/databar-ext-xform.spec.js):
Integration test (spec/integration/workbook-xlsx-writer/workbook-xlsx-writer.spec.js):
Test Results
All tests pass successfully (197 passing total, 2 pre-existing unrelated failures).
Related: exceljs#3015