updates on ci and add dependabot config #16
Conversation
| types: | ||
| - opened | ||
| - reopened | ||
| - synchronize |
There was a problem hiding this comment.
I would recommend reverting this, otherwise it will run any time there is any kind of update to a PR (e.g. title changes, it gets merged, someone comments, etc.)
There was a problem hiding this comment.
That does not happen, but i will revert
There was a problem hiding this comment.
Yep these would only trigger on a push to the branch and when the PR is (re)opened.
There was a problem hiding this comment.
Normally, it will trigger when you open/reopen/sync. If you want to trigger other actions, then you set it.
so that is redundant to set as those are the default triggers
There was a problem hiding this comment.
@cpanato Huh I didn't know that, they really didn't make it easy to find. Learn something new every day!
From the first paragraph under the notes here:
Runs your workflow when activity on a pull request in the workflow's repository occurs. For example, if no activity types are specified, the workflow runs when a pull request is opened or reopened or when the head branch of the pull request is updated.
Then again, to quote the Zen of Python, explicit is better than implicit 😄
Signed-off-by: cpanato <ctadeu@gmail.com>
3 participants
No description provided.