Skip to content

don't set bash options, use pipes instead #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marten-seemann merged 2 commits into from
May 13, 2021
Merged

don't set bash options, use pipes instead #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b4208d
don't set bash options, use pipes instead
marten-seemann May 13, 2021
9e486a3
simplify capturing of the subshell exit status
marten-seemann May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@ runs:
for dir in $(find . \( -name vendor -o -name '[._].*' -o -name node_modules \) -prune -o -name go.mod -print | sed 's:/go.mod$::'); do
echo "#=#=#=# $dir #=#=#=#"
pushd $dir > /dev/null
set +e -x
(
Copy link
Member

@Stebalien Stebalien May 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: you can also say:

if ! (
${{ inputs.run }}
); then
status = ...

I think?

Copy link
Contributor Author

@marten-seemann marten-seemann May 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it great that there are 20 different ways to do the easiest things in bash?

Copy link
Contributor Author

@marten-seemann marten-seemann May 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works, but we'd lose the exit status.

Copy link
Member

@Stebalien Stebalien May 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Yeah, that makes sense.

Isn't it great that there are 20 different ways to do the easiest things in bash?

Hm. That's way too few. We should switch everything to Perl.

${{ inputs.run }}
)
s=$?
set -e +x
if [[ $s != 0 ]]; then status=$s; fi
popd > /dev/null
echo -e "\n\n"
Expand Down