Integrate from Piper for C++, Java, and Python #10341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PROTOBUF_SYNC_PIPER
deannagarcia
reviewed
Aug 2, 2022
Member
deannagarcia
left a comment
deannagarcia
left a comment
There was a problem hiding this comment.
Any changes with proto relnotes to add to CHANGES.txt?
mkruskal-google
requested changes
Aug 2, 2022
Member
mkruskal-google
left a comment
mkruskal-google
left a comment
There was a problem hiding this comment.
Please revert extract_includes.bat.in, I'll remove it from google3 so we don't keep hitting this
Contributor
Author
|
@mkruskal-google PTAL |
mkruskal-google
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: this integration must be merged, not squashed!