[Mac] Support bazelisk and drop -j argument. #10412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruskal-google
requested changes
Aug 15, 2022
Member
mkruskal-google
left a comment
mkruskal-google
left a comment
There was a problem hiding this comment.
This LGTM but Kokoro is currently down, so let's wait till that actually runs
The support for -j was there since make didn't do parallel builds by default. Remove some references to the intermedia results of an autotools build.
thomasvl
force-pushed
the
autotools_followups
branch
from
b569ece to
e65be67
Compare
Contributor
Author
Ok, got a full kokoro run, so I think it is likely ready for complete review. |
mkruskal-google
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for -j was there since make didn't do parallel builds by default.