CMake: Check whether Abseil is already present in the current project #10436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should fix #10435 |
mkruskal-google
approved these changes
Aug 22, 2022
copybara-service bot
pushed a commit
to protocolbuffers/utf8_range
that referenced
this pull request
Oct 26, 2022
This is similar in spirit to my [Protobuf PR #10436](protocolbuffers/protobuf#10436) (as per [Protobuf Issue #10435](protocolbuffers/protobuf#10435)) PiperOrigin-RevId: 483934830
copybara-service bot
pushed a commit
to protocolbuffers/utf8_range
that referenced
this pull request
Oct 26, 2022
This is similar in spirit to my [Protobuf PR #10436](protocolbuffers/protobuf#10436) (as per [Protobuf Issue #10435](protocolbuffers/protobuf#10435)) PiperOrigin-RevId: 483934830
copybara-service bot
pushed a commit
to protocolbuffers/utf8_range
that referenced
this pull request
Oct 26, 2022
This is similar in spirit to my [Protobuf PR #10436](protocolbuffers/protobuf#10436) (as per [Protobuf Issue #10435](protocolbuffers/protobuf#10435)) PiperOrigin-RevId: 484007937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
absl::stringsalready exists at configure time, this means protobuf was likely included viaadd_subdirectory()from a parent project that also uses Abseil. Do not checkprotobuf_ABSL_PROVIDERin that case.