Improve CMake installation tests #10615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some cyclic logic in our installation tests, where we select which headers to remove from our CMake file_lists. We then build and run our tests, expecting our previously installed headers to get picked up. Since these lists are also used to determine which headers get installed, the fact that
port_def.incwas excluded from installation was missed.Instead, with this PR we glob and remove all
*.hand*.inc*files that haven't been explicitly grouped as test utilities.