Skip to content

Conversation

@thomasvl
Copy link
Contributor

No description provided.

@thomasvl thomasvl changed the title Objc clang format work [ObjC] Some prep work and then run clang-format over the ObjC runtime sources and tests Sep 20, 2022
@thomasvl thomasvl marked this pull request as ready for review September 20, 2022 12:49
- Minor formatting changes to make thing happy.
- Block clang-format from the PDDM macro definitions to avoid it wrapping
  things.
- Don't add clang-format directives to the expansion, easier to handling
  it outside of there.
@thomasvl thomasvl force-pushed the objc_clang_format_work branch from ba931c6 to 8dede5e Compare September 23, 2022 17:27
@thomasvl thomasvl removed the request for review from haberman September 23, 2022 17:28
@thomasvl
Copy link
Contributor Author

The Linux JRuby and Python failures look unrelated. The previous Kokoro runs passed, and the ObjC code won't be compiled on Linux.

@thomasvl thomasvl merged commit ecd63bb into protocolbuffers:main Sep 23, 2022
@thomasvl thomasvl deleted the objc_clang_format_work branch September 23, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants