Skip to content

Conversation

@mkruskal-google
Copy link
Member

build-protoc.sh and pom.xml are the only files we still use in this directory. The build script is still used for part of the release process, but will eventually be replaced and can be moved to the legacy release directories. The pom file is moved to the root directory

Copy link
Member

@deannagarcia deannagarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the idea of having a pom file in the root directory. I think it's pretty confusing (it would be very reasonable to assume that file also publishes the Java runtime).

I also don't want all the documentation about the Maven protoc package to be deleted.

Why is it a goal to delete this directory?

@mkruskal-google
Copy link
Member Author

Putting it in the root directory made the most sense to me, since this is the pom file for the protobuf compiler (rather than any java-specific thing). I'm open to moving it somewhere else, but I'm not sure where.

What value does this documentation provide? We're moving all our release code back to google3 so I don't see why any of our users would need this information on top of what we already provide in the other README files.

The main goal for deleting this directory is that it's a remnant of the legacy release process, and reducing the number of top level directories makes our repo less confusing.

@deannagarcia
Copy link
Member

Can we put this in java/protoc-artifacts? I want it to be explicit that it's just the compiler.

I didn't read all the documentation and I agree a lot is not needed anymore, but maybe a short README with what this publishes (including a list of supported architectures) and where it can be found.

@mkruskal-google
Copy link
Member Author

mkruskal-google commented Sep 21, 2022

Will this file survive the release migration? Or will we not need it once that's done? I think the answer to that will change how I feel about it living in java/protoc-artifacts.

@mkruskal-google mkruskal-google merged commit d0936c3 into protocolbuffers:main Sep 26, 2022
@mkruskal-google mkruskal-google deleted the protoc-artifacts branch September 27, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants