[ObjC] Clean up compiler/objectivec/names.h #10714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since "names.(h|cc)" now exists, drop the prefixing on all the files.
There are still some things not related to naming in naming.h, but they are current exposed for gRPC to use.
Make a new (private to the package) target for this so names can depend on it as an implementation detail as well as the other generator code. Split the names unittests to have the LineConsumer out on its own also.
Dropping the custom impl that was used previously.
These aren't public api, but this is currently need for how the CMake build is configured.
mkruskal-google
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the TODO by removing things from compiler/objectivec/objectivec_helpers.h.
objectivec_prefix (to align withnames.(h|cc).names.hthat should be in other files and not documented api for external things.