Main 202212021626 #11138
Merged
Main 202212021626 #11138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#10845) * Add bazel php:release target for PECL tgz using generated package.xml * move targets from php/ext/google/protobuf to php packages since this breaks dist_files and add utf8 license file * Remove package.xml form Makefile.am * add files to Makefile.am
… of fields. Changes to make this improvement: 1) All non-repeated builder fields (including maps) now have a presence bit regardless of syntax. 2) The buildPartial method is split into one method per 32-field block (aligned with bit-mask ints) 3) If a presence bit-mask int is set to 0, no fields are present, so we can skip the logic for all of those fields in the buildPartial step. For messages with a lot of fields (> 100) that are sparsely populated this can result in a significant improvement. Not only does it potentially skip a lot of field copying logic, but also breaks the buildPartial method into chunks that should be more easily digested by the JIT compiler as discussed in this issue: #10247. PiperOrigin-RevId: 485952448
Use bit-field int values in buildPartial to skip work on unset groups of fields.
Omitting this step was leading to stale cached versions of nested messages. See #10624
This will be used in verfication of #10624
Verify fix for #10624
…d-builder-fix Fix stale cached submessages by marking nested builder as clean after clear is called
Add public modifiers to kotlin code
CocoaPods/CocoaPods#11558 is causing this GHA to fail. It has been resolved in main, but this will continue to fail until a release is out and we migrate to it.
Disable CocoaPods watchOS validation
21.x 202211281808
21.x 202211291338
Update version.json to: 21.11-dev
My previous attempt to do this #11068 (comment) missed this instance.
Add "public" modifier to Kotlin generated code
jorgbrown
added
the
mergeable:force-allow
mkruskal-google
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge release branch 21.x in to main