Strip "src" from file name of plugin.proto #11991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 22.x, we accidentally omitted stripping the "src" import prefix for plugin.proto. We stripped the prefix in 21.x and for all other well known types in 22.x. This reverts that unintentional change.
mkruskal-google
approved these changes
Feb 17, 2023
copybara-service bot
pushed a commit
to protocolbuffers/upb
that referenced
this pull request
Mar 20, 2023
This also requires some editing in the rewrites since importing plugin.proto shouldn't require the src prefix after protocolbuffers/protobuf#11991. PiperOrigin-RevId: 518067731
copybara-service bot
pushed a commit
to protocolbuffers/upb
that referenced
this pull request
Mar 21, 2023
This also requires some editing in the rewrites since importing plugin.proto shouldn't require the src prefix after protocolbuffers/protobuf#11991. PiperOrigin-RevId: 518387501
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
This also requires some editing in the rewrites since importing plugin.proto shouldn't require the src prefix after protocolbuffers#11991. PiperOrigin-RevId: 518387501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 22.x, we accidentally omitted stripping the "src" import prefix for plugin.proto. We stripped the prefix in 21.x and for all other well known types in 22.x.
This reverts that unintentional change.