Update Bazel references to rules_pkg to the supported file locations.#15780
Update Bazel references to rules_pkg to the supported file locations.#15780aiuto wants to merge 1 commit intoprotocolbuffers:mainfrom
Conversation
3 scripted transforms:
```
-load("@rules_pkg//:mappings.bzl", ...)
+load("@rules_pkg//pkg:mappings.bzl", ...)
```
```
-load("@rules_pkg//:pkg.bzl", "pkg_tar")
+load("@rules_pkg//pkg:tar.bzl", "pkg_tar")
```
```
-load("@rules_pkg//:pkg.bzl", "pkg_zip")
+load("@rules_pkg//pkg:zip.bzl", "pkg_zip")
```
aiuto
requested review from
acozzette and
anandolee
and removed request for
a team
zhangskz
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
|
I think this would also requires updating https://github.com/protocolbuffers/protobuf/blob/main/protobuf_deps.bzl#L116 to >= 0.7.1 as well since this seems to be where pkg:mappings.bzl was introduced. |
|
I left that out |
Ah even better, thanks! |
…protocolbuffers#15780) WIP: I want to see this pass CI first. Fixes: protocolbuffers#15779 3 scripted transforms: ``` -load("@rules_pkg//:mappings.bzl", ...) +load("@rules_pkg//pkg:mappings.bzl", ...) ``` ``` -load("@rules_pkg//:pkg.bzl", "pkg_tar") +load("@rules_pkg//pkg:tar.bzl", "pkg_tar") ``` ``` -load("@rules_pkg//:pkg.bzl", "pkg_zip") +load("@rules_pkg//pkg:zip.bzl", "pkg_zip") ``` Closes protocolbuffers#15780 COPYBARA_INTEGRATE_REVIEW=protocolbuffers#15780 from aiuto:rules_pkg a630276 PiperOrigin-RevId: 606641398
3 participants
WIP: I want to see this pass CI first.
Fixes: #15779
3 scripted transforms: