Migrate proto_descriptor_set
#23369
Closed
Migrate proto_descriptor_set
#23369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turmanticant
reviewed
Sep 4, 2025
turmanticant
left a comment
turmanticant
left a comment
There was a problem hiding this comment.
Would love to see this get added 😁
SpencerC
force-pushed
the
proto_descriptor_set
branch
from
9d9bd66 to
2b99f07
Compare
|
+1 -- we also use this, and the lack of |
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
SpencerC
force-pushed
the
proto_descriptor_set
branch
from
2b99f07 to
8016162
Compare
mkruskal-google
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
added
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
mkruskal-google
approved these changes
Oct 1, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
This is just a straightforward copy of https://github.com/bazelbuild/rules_proto/blob/main/proto/private/rules/proto_descriptor_set.bzl with the related tooling and test files. The only modifications are: - Changed paths to match the organization of this repo - Included constants directly in the test file instead of a separate header in a separate directory. Closes #19647 Closes #23369 COPYBARA_INTEGRATE_REVIEW=#23369 from SpencerC:proto_descriptor_set 24b517b FUTURE_COPYBARA_INTEGRATE_REVIEW=#23369 from SpencerC:proto_descriptor_set 24b517b PiperOrigin-RevId: 813766298
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 2, 2025
This is just a straightforward copy of https://github.com/bazelbuild/rules_proto/blob/main/proto/private/rules/proto_descriptor_set.bzl with the related tooling and test files. The only modifications are: - Changed paths to match the organization of this repo - Included constants directly in the test file instead of a separate header in a separate directory. Closes #19647 Closes #23369 COPYBARA_INTEGRATE_REVIEW=#23369 from SpencerC:proto_descriptor_set 24b517b FUTURE_COPYBARA_INTEGRATE_REVIEW=#23369 from SpencerC:proto_descriptor_set 24b517b PiperOrigin-RevId: 813766298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a straightforward copy of https://github.com/bazelbuild/rules_proto/blob/main/proto/private/rules/proto_descriptor_set.bzl with the related tooling and test files. The only modifications are:
Closes #19647