Stop forcing linker array entries to be retained. They will now be GC'd like normal, but will be iterable if retained. #23378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'d like normal, but will be iterable if retained. There was no need to force them to be retained. Extensions only need to be retained if they are referenced, and normal linker GC can tell us if they are referenced. This will make the ExtensionRegistry linker array agnostic to how extensions are packaged into TUs. However, TUs are still relevant if we want to perform "implicit weak" static tree shaking, because any extensions that are colocated in the same file will cause all referenced sub-message types to be pulled into the link. But this is no worse than what we get for regular messages -- for implicit weak we should always put every message and every extension into its own TU. PiperOrigin-RevId: 803130581
copybara-service
bot
force-pushed
the
test_802760923
branch
from
d716f3f to
df180e2
Compare
robertkirkman
added a commit
to robertkirkman/termux-packages
that referenced
this pull request
Nov 13, 2025
- partially revert protocolbuffers/protobuf#23378 to prevent error `ld.lld: error: undefined symbol: __stop_linkarr_upb_AllExts`
robertkirkman
added a commit
to robertkirkman/termux-packages
that referenced
this pull request
Nov 13, 2025
- partially revert protocolbuffers/protobuf#23378 +to prevent error `ld.lld: error: undefined symbol: __stop_linkarr_upb_AllExts`
TomJo2000
pushed a commit
to termux/termux-packages
that referenced
this pull request
Nov 14, 2025
- partially revert protocolbuffers/protobuf#23378 to prevent error `ld.lld: error: undefined symbol: __stop_linkarr_upb_AllExts`
TomJo2000
pushed a commit
to termux/termux-packages
that referenced
this pull request
Nov 14, 2025
- partially revert protocolbuffers/protobuf#23378 +to prevent error `ld.lld: error: undefined symbol: __stop_linkarr_upb_AllExts`
termux-pacman-bot
added a commit
to termux-pacman/termux-packages
that referenced
this pull request
Nov 14, 2025
- partially revert protocolbuffers/protobuf#23378 to prevent error `ld.lld: error: undefined symbol: __stop_linkarr_upb_AllExts`
termux-pacman-bot
added a commit
to termux-pacman/termux-packages
that referenced
this pull request
Nov 14, 2025
- partially revert protocolbuffers/protobuf#23378 +to prevent error `ld.lld: error: undefined symbol: __stop_linkarr_upb_AllExts`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop forcing linker array entries to be retained. They will now be GC'd like normal, but will be iterable if retained.
There was no need to force them to be retained. Extensions only need to be retained if they are referenced, and normal linker GC can tell us if they are referenced.
This will make the ExtensionRegistry linker array agnostic to how extensions are packaged into TUs. However, TUs are still relevant if we want to perform "implicit weak" static tree shaking, because any extensions that are colocated in the same file will cause all referenced sub-message types to be pulled into the link. But this is no worse than what we get for regular messages -- for implicit weak we should always put every message and every extension into its own TU.