feat(php): support default values for editions/proto2 #25161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

bshaffer wants to merge 9 commits into protocolbuffers:main from bshaffer:php-fix-ignored-default-fields

Contributor

bshaffer commented Jan 5, 2026 •

edited

Loading

b/435022198


          feat(php): support default values for editions/proto2

e0a894b

bshaffer requested a review from a team as a code owner

January 5, 2026 19:28

bshaffer requested review from ericsalo and removed request for a team

January 5, 2026 19:28

bshaffer added the 🅰️ safe for tests label

bshaffer marked this pull request as draft

January 5, 2026 19:28

mkruskal-google self-requested a review

January 5, 2026 19:29

github-actions bot removed the 🅰️ safe for tests label


          add support editions as a php feature

5f641bc

bshaffer added the 🅰️ safe for tests label

github-actions bot removed the 🅰️ safe for tests label

bshaffer commented

View reviewed changes

src/google/protobuf/compiler/php/php_generator.h Show resolved Hide resolved


          fix namespace

32845b4

bshaffer added the 🅰️ safe for tests label

github-actions bot removed the 🅰️ safe for tests label

bshaffer added 2 commits

January 5, 2026 12:47


          fix tests to expect strings for 32-bit platforms

f556bdd


          fixes for 32-bit system - adds GPBUtil::compatibleInt64

2ec2aed

bshaffer marked this pull request as ready for review

January 5, 2026 21:07

bshaffer added the 🅰️ safe for tests label

github-actions bot removed the 🅰️ safe for tests label


          fix compatibleInt64, add it to the extension

ebd7e55

bshaffer added the 🅰️ safe for tests label

github-actions bot removed the 🅰️ safe for tests label


          fix c-extension GPBUtil::compatibleInt64

6087ede

bshaffer added the 🅰️ safe for tests label

github-actions bot removed the 🅰️ safe for tests label


          adds DefaultForFieldWithPresence

7b3d966

bshaffer added the 🅰️ safe for tests label

github-actions bot removed the 🅰️ safe for tests label


          add getter check

16706c0

bshaffer added the 🅰️ safe for tests label

github-actions bot removed the 🅰️ safe for tests label

mkruskal-google reviewed

View reviewed changes

src/google/protobuf/compiler/php/php_generator.cc

    
                    case FieldDescriptor::CPPTYPE_STRING:

                      return "'" + absl::CEscape(field->default_value_string()) + "'";

                    case FieldDescriptor::CPPTYPE_MESSAGE:

                      return "null";

Member

mkruskal-google Jan 7, 2026

This should be unreachable, might as well ABSL_CHECK

Contributor Author

bshaffer Jan 7, 2026

Something like this?

Suggested change

      
                    return "null";
          
                    ABSL_CHECK(false) << "Message fields cannot have default values."; 
          
                    return "null";

mkruskal-google approved these changes

View reviewed changes

copybara-service bot closed this in

b01099d

protobuf-team-bot added a commit that referenced this pull request


          Auto-generate files after PR #25161

64bc872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet