Skip to content

Disable python tests on windows#25598

Merged
mkruskal-google merged 1 commit into29.xfrom
setup-py-fix
Jan 30, 2026
Merged

Disable python tests on windows#25598
mkruskal-google merged 1 commit into29.xfrom
setup-py-fix

Conversation

@mkruskal-google
Copy link
Member

@mkruskal-google mkruskal-google commented Jan 30, 2026

These were never supported (due to issues in system_python), and always fell back to the incompatible system_python path anyway. For some reason our mechanism for skipping these builds seems to have failed on the source_wheels genrule. Disabling them entirely is easy and doesn't actually reduce coverage at all

@mkruskal-google mkruskal-google requested a review from a team as a code owner January 30, 2026 02:15
@mkruskal-google mkruskal-google requested review from deannagarcia and removed request for a team January 30, 2026 02:15
@mkruskal-google mkruskal-google changed the title Debug setup.py issue Disable python tests on windows Jan 30, 2026
@mkruskal-google mkruskal-google requested review from esrauchg and removed request for deannagarcia January 30, 2026 02:33
@mkruskal-google mkruskal-google merged commit cbfc703 into 29.x Jan 30, 2026
191 checks passed
@mkruskal-google mkruskal-google deleted the setup-py-fix branch January 30, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants