Skip to content

Merge branch#4466

Merged
TeBoring merged 5 commits intoprotocolbuffers:masterfrom
TeBoring:merge-branch
Apr 2, 2018
Merged

Merge branch#4466
TeBoring merged 5 commits intoprotocolbuffers:masterfrom
TeBoring:merge-branch

Conversation

@TeBoring
Copy link
Copy Markdown
Contributor

@TeBoring TeBoring commented Apr 2, 2018

Merge 3.5.x to master.

@TeBoring TeBoring requested a review from liujisi April 2, 2018 17:51
@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot
Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@TeBoring TeBoring merged commit c931743 into protocolbuffers:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants