Use requirements.txt in GHA tests #1237
Conversation
| - uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: requirements | ||
| path: python/requirements.txt |
There was a problem hiding this comment.
Where is the source of truth for this file? Where does the data come from? A comment would be helpful.
There was a problem hiding this comment.
What do you mean by that? The file is just being pulled out of the repository.
There was a problem hiding this comment.
Oh I see. I thought maybe it was coming from a genrule().
Does it need to be uploaded at all then? Could we use a regular checkout action to obtain it?
There was a problem hiding this comment.
I only wanted requirements.txt to be available to us and not the rest of the repository (to ensure we aren't erroneously depending on another aspect of the repository).
Is it possible to do that with checkout?
There was a problem hiding this comment.
Makes sense. A comment to that effect would be helpful. Otherwise I would assume that any artifact you are uploading was produced by the build process. It would help to know the rationale for why a source was being uploaded as an artifact.
There was a problem hiding this comment.
Makes sense, added a comment!
2 participants
We recently saw a failure pass through where requirements.txt was updated in a way that was not compatible with some python versions. This updates the tests to directly use requirements.txt to download requirements to catch issues like this in the future.