add the architecture doc by think-in-universe · Pull Request #144 · protofire/solhint

think-in-universe · 2019-08-27T17:23:57Z

Description

Add the architecture doc for the issue #140

Details

Project Structure
ANTLR Grammar with solidity-antlr4
How to Add a New Rule, A Plugin or A Shared Configuration

coveralls · 2019-08-27T17:26:02Z

Coverage remained the same at 97.856% when pulling 4e0b6f0 on think-in-universe:master into 84648ca on protofire:master.

fvictorio · 2019-08-27T18:49:07Z

Thanks @think-in-universe! I made some modifications, but I think this is close to good enough. I'll wait for @ChrisChinchilla to take a look before approving this.

think-in-universe · 2019-08-27T18:54:14Z

@fvictorio sure. thanks. 😄

think-in-universe · 2019-08-29T07:45:59Z

@ChrisChinchilla any feedback or suggestions?

think-in-universe · 2019-08-31T13:22:58Z

Hi @fvictorio @ChrisChinchilla, any update or feedback for the document?

docs/architecture.md

ChrisChinchilla · 2019-09-02T08:44:08Z

@think-in-universe Couple of small things and we're good to go 👍

Co-Authored-By: Chris Chinchilla <chriswhward@gmail.com>

think-in-universe · 2019-09-02T13:16:21Z

@ChrisChinchilla cool. Thanks for the suggestions and I have updated the doc.

ChrisChinchilla · 2019-09-03T14:04:17Z

Merge away @fvictorio ! Then we'll pay the bounty out asap too.

fvictorio · 2019-09-03T17:09:42Z

Thanks @think-in-universe!

think-in-universe · 2019-09-04T04:41:40Z

thank you guys @fvictorio @ChrisChinchilla

add the architecture doc

0089651

think-in-universe mentioned this pull request Aug 27, 2019

Document the structure of the project #140

Closed

think-in-universe and others added 4 commits August 28, 2019 01:59

add commands for updating rule docs

2cd7ead

update generate rule docs commands

b323827

fix typos

f8be074

Rephrase and fix typos in architecture document

98d53d4

fix some typo

4376a78

ChrisChinchilla reviewed Sep 2, 2019

View reviewed changes