fix(npm): commit root launcher package; anchor .gitignore binary patterns#1
Merged
Conversation
The bare 'csdd' / 'csdd.md' ignore patterns matched at any depth, so the entire npm/csdd/ launcher package (bin/csdd.js, package.json, README.md) was silently ignored and never committed. The release workflow's build-packages.mjs then failed in CI with ENOENT on npm/csdd/bin/csdd.js, breaking npm publishing. Anchor both patterns to the repo root (/csdd, /csdd.md) so they only ignore the compiled binary and generated guide, and commit the launcher package files. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The first
v0.1.0release run built all 5 binaries and the GitHub Release fine, but thepublish npm packagesjob failed with:Root cause: the root
.gitignorehad barecsdd/csdd.mdpatterns. Without a leading slash, gitignore matches at any depth, so the pattern silently swallowed the entirenpm/csdd/launcher package. Onlynpm/.gitignore,npm/README.md, andnpm/scripts/build-packages.mjswere ever tracked —npm/csdd/{bin/csdd.js,package.json,README.md}were never committed, so CI'sbuild-packages.mjscouldn't find them.Fix
/csddand/csdd.md. They still ignore the compiled binary and generated guide at the root, but no longer matchnpm/csdd/.npm/csdd/bin/csdd.js,npm/csdd/package.json,npm/csdd/README.md).Verified
git check-ignore csdd→ still ignored (root binary stays out).git check-ignore npm/csdd/bin/csdd.js→ no longer ignored.build-packages.mjs→npm publish --dry-run) assembles all 6 packages cleanly.Without this, every future
v*tag's auto-publish job will keep hitting the same ENOENT. Thev0.1.0npm packages themselves are being published via the documented manual bootstrap, which is unaffected.🤖 Generated with Claude Code