fix(ci): pin release artifact download to binaries-* pattern#28
Merged
Conversation
actions/download-artifact@v4 without an explicit pattern enumerates every artifact in the run, which intermittently hits a 5-retry failure on GHA's backend even when our 4 matrix uploads land cleanly. Restrict the download to binaries-* so the action stops trying to fetch unrelated internal artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rc.2 release job failed twice (initial + retry) at the `download all artifacts` step. Logs show 4 of our matrix uploads downloaded cleanly, then `actions/download-artifact@v4` tried a 5th and exhausted its retries.
Root cause: without an explicit `pattern`, v4 enumerates every artifact in the workflow run via the GHA API and downloads each. Some runs include internal artifacts that intermittently fail to fetch.
Fix: pin `pattern: binaries-*` so the action only downloads our 4 matrix uploads.
Test plan
After merge:
```
git tag v0.1.0-rc.3
git push --tags
```
Expect: 8 archives + 8 `.sha256` sidecars attached to a GitHub Pre-release. Container will rebuild but should be fast (cache hit on layers; only the manifest tag needs updating). Total run time: ~25-30 min.
rc.1 + rc.2 stay on the timeline as recorded learning.
Refs #24.