refactor(deletion): isolate steps to remove blocks#7332
refactor(deletion): isolate steps to remove blocks#7332
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7332 +/- ##
==========================================
- Coverage 92.25% 92.17% -0.09%
==========================================
Files 81 81
Lines 7374 7375 +1
==========================================
- Hits 6803 6798 -5
- Misses 571 577 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
drewkerrigan
left a comment
drewkerrigan
left a comment
There was a problem hiding this comment.
Worth a try - the risk I guess is some orphaned data, but it should be easy to find if that happens.
| deletion_summary.update(step_summary) | ||
| except DatabaseError as error: | ||
| logger.error(f"Error deleting {step_name}: {error}") | ||
| raise |
There was a problem hiding this comment.
| raise | |
| raise error |
There was a problem hiding this comment.
Not needed. Python will raise the captured exception by default.
| deletion_summary.update(provider_summary) | ||
| except DatabaseError as error: | ||
| logger.error(f"Error deleting Provider: {error}") | ||
| raise |
There was a problem hiding this comment.
| raise | |
| raise error |
There was a problem hiding this comment.
Not needed. Python will raise the captured exception by default.
|
Closing this since it is implemented in #7349 |
3 participants
Context
Please include relevant motivation and context for this PR.
If fixes an issue please add it with
Fix #XXXXDescription
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.