fix(ui): Improved the findings page scan Id filter #7827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paabloLC
suggested changes
May 28, 2025
Contributor
paabloLC
left a comment
paabloLC
left a comment
There was a problem hiding this comment.
After our huddle, @sumit-tft is working on some refactoring here. (just dropping an update)
…provement # Conflicts: # ui/CHANGELOG.md # ui/app/(prowler)/findings/page.tsx # ui/components/ui/custom/custom-dropdown-filter.tsx # ui/types/filters.ts
…provement # Conflicts: # ui/CHANGELOG.md # ui/components/ui/custom/custom-dropdown-filter.tsx
…provement # Conflicts: # ui/CHANGELOG.md # ui/app/(prowler)/compliance/page.tsx # ui/types/components.ts
alejandrobailo
requested changes
Jun 5, 2025
| entityAlias={entity.alias ?? undefined} | ||
| entityId={entity.uid} | ||
| hideCopyButton | ||
| /> |
Contributor
There was a problem hiding this comment.
What about cloud providers? You are removing this:
Contributor
Author
There was a problem hiding this comment.
@alejandrobailo, thanks for the comment! I used the ComplianceScanInfo it already had EntityInfoShort so I don't think it will break also we don't have to use EntityInfoShort explicitly in this component.
Please let me know if I misunderstood. Thanks!
8 tasks
Contributor
|
I've created this Pull request as a proposal: #7949 |
…provement # Conflicts: # ui/components/ui/custom/custom-dropdown-filter.tsx
Contributor
|
@sumit-tft as we agreed, I'm closing this PR so we can move forward with Alex's proposal. Thanks a lot for laying the groundwork for this functionality! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces the changes in findings Scan Id filter to improve its usability
Description
The Scan ID filter for findings updated to have now more context same as we have for compliance, to include the icon, alias, provider id, name and completed at.
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.