Use rust_shared_library for building Wasm modules.#512
Merged
leonm1 merged 2 commits intoproxy-wasm:mainfrom Mar 10, 2026
Merged
Use rust_shared_library for building Wasm modules.#512leonm1 merged 2 commits intoproxy-wasm:mainfrom
leonm1 merged 2 commits intoproxy-wasm:mainfrom
Conversation
The rust_binary(out_binary=True) hack is no longer needed, and we can remove the patch for it. Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
PiotrSikora
requested review from
leonm1,
martijneken and
mpwarres
as code owners
Member
Author
|
cc @phlax @mmorel-35 |
phlax
approved these changes
Mar 7, 2026
Contributor
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
great, thanks @PiotrSikora
mmorel-35
approved these changes
Mar 7, 2026
leonm1
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rust_binary(out_binary=True) hack is no longer needed,
so we can remove the patch for it.