chore: uses edition 2021 #152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hao Xin <haoxinst@gmail.com>
PiotrSikora
reviewed
May 3, 2022
Member
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
This is fine, since hashbrown dependency already forces us to use a Rust compiler that supports edition = 2021, but I'm wondering if edition change requires a version bump (preferrably not)?
Also, there are a few more places where edition needs to be updated for Bazel builds (BUILD and examples/BUILD).
cc @Swaagie who suggested this change earlier in #129 and #133, but we dropped it since it wasn't required after all.
Contributor
|
Probably good to move forward with latest edition. Test and builds were passing with 2021, but as @PiotrSikora mentioned it requires a few more updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.