Add launchd plist template for daemon mode#11
Merged
munezaclovis merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
Introduce internal/daemon package with plist generation for running pv as a launchd service. Renders dynamic XML with user-specific paths, environment variables, and KeepAlive/RunAtLoad support. Also updates the daemon feature plan to include e2e test tasks following the project's bash script conventions.
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/daemon/package with plist generation (PlistConfig,RenderPlist,WritePlist,RemovePlist,DefaultPlistConfig)KeepAlive: true,RunAtLoadtoggle, and environment variables (XDG_DATA_HOME,PATH)docs/features/daemon.mdwith full implementation plan including e2e test tasks (bash scripts matching project conventions)Test plan
go test ./internal/daemon/ -v— all 14 tests passgo test ./...— full suite passes, no regressions