Trim daemon e2e tests to 3 focused scripts#13
Merged
munezaclovis merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
Existing foreground e2e tests already cover DNS, HTTP, restart, and log behavior. Reduce daemon-specific e2e tests to only what requires real launchd integration: start/stop lifecycle, crash recovery, and full stack. Drops 7 redundant scripts, renumbers tasks 12-13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start-curl.sh,restart.sh,log.sh,stop.sh) already cover DNS, HTTP, restart, and log behavior — no need for daemon-specific duplicatesdaemon-start-stop.sh— launchd load/unload lifecycle, plist verificationdaemon-crash-recovery.sh— kill -9 + PID check (proves KeepAlive works)daemon-full-stack.sh— link project + daemon start + curl (proves env vars work)Test plan
go test ./...still passes (no code changes)