Unify release flow: keep FrankenPHP assets on pv releases#21
Merged
munezaclovis merged 1 commit intomainfrom Mar 5, 2026
Merged
Unify release flow: keep FrankenPHP assets on pv releases#21munezaclovis merged 1 commit intomainfrom
munezaclovis merged 1 commit intomainfrom
Conversation
- release.yml: copy frankenphp-* assets from previous release to new release after GoReleaser runs, so every pv release has PHP binaries - build-frankenphp.yml: upload rebuilt FrankenPHP assets to the latest v* pv release instead of creating a separate frankenphp-* release
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v*release, automatically copyfrankenphp-*assets from the previous release so every pv release ships with PHP binaries out of the box.v*pv release (with--clobber) instead of creating a separatefrankenphp-*tagged release.This ensures
pv installalways works —AvailableVersions()hits/releases/latest, and that release will always havefrankenphp-*assets.