Revamp CLI output with lipgloss-powered UI#22
Merged
munezaclovis merged 4 commits intomainfrom Mar 6, 2026
Merged
Conversation
Create internal/ui package with spinner, progress bar, styled helpers, and lipgloss table rendering. Refactor all commands to use consistent styled output: spinners for async operations, checkmarks for success, styled errors that don't duplicate messages. - Add charmbracelet/lipgloss dependency for terminal styling - Create internal/ui with spinner, progress bar, table, and style helpers - Colors match install.sh (purple accent, green success, red errors) - Refactor pv install/update with 8 clean spinner steps + progress bar - Add --verbose flag to install and update commands - Suppress child process output by default (binaries, phpenv, setup) - Acquire sudo credentials upfront to avoid password prompt during spinners - Prettify all commands: status, list, link, unlink, start, stop, restart, service, use, php install/list/remove - Use lipgloss table with rounded borders for site listings - Add ErrAlreadyPrinted sentinel to prevent duplicate error messages - Set SilenceErrors on rootCmd so cobra never prints raw errors - Add footer with elapsed time for install/update
Contributor
Author
|
@claude fix the failing e2e.yml tests! We're been changing the ui for a lot of these commands so I guess this might've broken the e2e tests |
|
Claude finished @munezaclovis's task in 5m 47s —— View job Fixing failing e2e testsRoot cause: The UI revamp moved all CLI output to
Changes pushed in commit
| |
The UI revamp moved all CLI output to os.Stderr for lipgloss styling. E2e scripts were capturing stdout only; add 2>&1 to capture stderr too. Also update assertions to match the new output format. Co-authored-by: Clovis <munezaclovis@users.noreply.github.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
@claude Lets revert the "(default)" -> "(global)" change. |
|
Claude finished @munezaclovis's task in 1m 16s —— View job Reverted "(global)" → "(default)"
Changes in commit
|
Reverts the "(global)" label back to "(default)" in both the Go source (php_list.go, status.go) and the e2e test scripts. Co-authored-by: Clovis <munezaclovis@users.noreply.github.com>
Installing an already-installed PHP version now succeeds (exit 0) with a friendly checkmark message, like mkdir -p on an existing directory. Update e2e test to match.
munezaclovis
added a commit
that referenced
this pull request
Mar 6, 2026
Apply UI styling (spinners via ui.Step) from PR #22 to the renamed daemon.go, and remove the now-obsolete service.go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/uipackage with spinner, progress bar, styled helpers, and lipgloss table renderinginstall.shcolors (purple accent, green success, red errors, muted gray)charmbracelet/lipglossdependency for terminal stylingWhat changed
pv install/pv update: 8 clean spinner steps, progress bar for PHP downloads,--verboseflag, elapsed time footerpv status: Colored status indicator (green/red dot), lipgloss table for sitespv list: Lipgloss table with rounded purple borderspv link/pv unlink: Styled success/error with clickablehttps://URLspv start/pv stop/pv restart: Spinners for async ops, clean error statespv use: Version transition arrow (8.4 → 8.5)pv php install/list/remove: Spinners, progress bars, styled errorspv service install/uninstall: Spinners for daemon operationsVerboseflag)ErrAlreadyPrintedsentinel prevents duplicate error messages from cobraTest plan
go test ./...passespv install --forceshows spinner steps with checkmarkspv statusshows colored tablepv listshows lipgloss table with borderspv link/pv unlinkshow styled messages, no duplicate errorspv restartwhen stopped shows clean message (no usage dump)pv php listshows colored version list