Replace .pv-php with pv.yml and add php:current command#30
Merged
munezaclovis merged 3 commits intomainfrom Mar 9, 2026
Merged
Replace .pv-php with pv.yml and add php:current command#30munezaclovis merged 3 commits intomainfrom
munezaclovis merged 3 commits intomainfrom
Conversation
Migrate per-project PHP version config from `.pv-php` (plain text) to `pv.yml` (YAML), enabling future extensibility (services, env, etc.). Add `pv php:current` command that walks up from $PWD, resolves the PHP version from pv.yml → composer.json → global default, and prints it to stdout. The PHP shim now delegates version resolution to this command instead of doing its own bash-based parsing. Also includes unrelated colima/lima and setup TUI changes.
Tests direct output, walk-up resolution, and pv.yml priority over composer.json alongside the existing shim tests.
…es, and clean up - Surface pv.yml parse errors instead of silently falling through to wrong PHP version - Remove 2>/dev/null from PHP shim so php:current errors are visible - Remove worker directive from non-Octane Caddy templates (fixes FrankenPHP crash on standard Laravel apps) - Fix symlink error handling in extractTarGz - Inherit caller's transport/timeout in latestLimaVersion and validate HTTP status - Use safe type assertion in setup wizard - Surface InstalledVersions/LoadSettings errors in setup - Update colima command descriptions to mention Lima - Add ~/.pv/internal/lima/ to CLAUDE.md binary storage rules - Remove dead os.IsNotExist check on RemoveAll - Update e2e fixtures to use plain PHP for non-Octane sites - Delete outdated plan.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.pv-phpfiles withpv.yml(php: "8.4") for future extensibility (services, env injection, etc.)pv php:currentcommand that walks up from$PWD, resolves PHP version (pv.yml→composer.json→ global default), and prints to stdoutpv php:currentProjectConfigtype tointernal/config/for readingpv.ymlfilespv.ymlTest plan
internal/config/pvyml_test.go(YAML parsing variants, walk-up, edge cases)internal/commands/php/current_test.go(pv.yml, composer.json, walk-up, priority, global fallback, error cases)internal/phpenv/resolve_test.go(updated from .pv-php to pv.yml, added walk-up tests)cmd/uninstall_test.gofor pv.yml referencesgo test ./...passes