Refactor link command into unified pipeline orchestrator#41
Merged
munezaclovis merged 9 commits intomainfrom Mar 13, 2026
Merged
Refactor link command into unified pipeline orchestrator#41munezaclovis merged 9 commits intomainfrom
munezaclovis merged 9 commits intomainfrom
Conversation
Approved design for making all link-time operations flow through the automation pipeline as Steps, replacing inline logic in cmd/link.go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunPipelinecall — PHP install, Caddyfile generation, TLS certs, service detection, and all Laravel-specific stepsCritical() booladded to Step interface — critical step failures abort the pipeline, non-critical failures continue with a visual✗cmd/link.goreduced from 250 to 170 lines — thin orchestrator that builds context, assembles step list, runs one pipelinegenerate_site_config,generate_caddyfile,generate_tls_cert,detect_services) — configurable viapv.ymlbut not shown in setup wizardInstallOctaneStep.Run()— step owns its own side effectsinternal/automation/steps/—cmd/link_services.godeletedTest plan
go test ./...— all 27 packages passgo vet ./...— cleangofmt -w .— cleanpv linkon a Laravel project verifies full pipeline runspv linkon a static/PHP project skips Laravel steps cleanlyinstall_php_version: falseinpv.yml, link project needing different PHP — verify warning shown