Skip to content

Conversation

@fjtrujy
Copy link
Member

@fjtrujy fjtrujy commented Jan 10, 2025

Create specific functions to make it easier to deal with the finish handler interruption.
Additionally I have enabled also LTO

@rickgaiser
Copy link
Member

What happens to:

gsKit/ee/gs/src/gsCore.c

Lines 124 to 127 in 2897eec

void gsKit_finish(void)
{
while(!(GS_CSR_FINISH));
}

After registering a finish handler? Can they be used at the same time?

@fjtrujy
Copy link
Member Author

fjtrujy commented Jan 10, 2025

What happens to:

gsKit/ee/gs/src/gsCore.c

Lines 124 to 127 in 2897eec

void gsKit_finish(void)
{
while(!(GS_CSR_FINISH));
}

After registering a finish handler? Can they be used at the same time?

Yes, actually it is still being used

@rickgaiser
Copy link
Member

Then it LGTM

@fjtrujy fjtrujy merged commit b5afab2 into ps2dev:master Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants