Open
Conversation
gsKit_prim_triangle_gouraud used the right bsize and qsize, but not gsKit_prim_triangle. I am surprised it took 20 years for someone to notice.
Author
|
I know it's wrong but I am not sure if my fix is right |
Member
Author
Author
|
@rickgaiser Ok sorry for that, last push fixes it I was still getting the ropes of stuff, shouldn't have been so sure that was enough to fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



gsKit_prim_triangle_gouraud used the right bsize and qsize, but not gsKit_prim_triangle. I am surprised it took 20 years for someone to notice.
It also needs GIF_AD to work for some reason
Fixes #98