refactor: use extern for forward decls in headers #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
What's the main difference we get with this change? |
Member
Author
|
It basically makes it easier to determine (e.g. from regex) what is a function prototype. |
Member
|
Please solve conflicts |
uyjulian
force-pushed
the
extern_forward_decls
branch
from
aaffa69 to
0b3c5f6
Compare
Member
Author
|
Done |
362053534
pushed a commit
to 362053534/ps2sdk
that referenced
this pull request
Aug 3, 2025
refactor: use extern for forward decls in headers
362053534
pushed a commit
to 362053534/ps2sdk
that referenced
this pull request
Aug 3, 2025
refactor: use extern for forward decls in headers
362053534
pushed a commit
to 362053534/ps2sdk
that referenced
this pull request
Aug 3, 2025
refactor: use extern for forward decls in headers
362053534
pushed a commit
to 362053534/ps2sdk
that referenced
this pull request
Aug 3, 2025
refactor: use extern for forward decls in headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.