Skip to content

Generate Invoke-Build Tasks from Psake Tasks#11

Merged
devblackops merged 9 commits intopsake:masterfrom
JustinGrote:feature/GenerateInvokeBuild
Nov 23, 2018
Merged

Generate Invoke-Build Tasks from Psake Tasks#11
devblackops merged 9 commits intopsake:masterfrom
JustinGrote:feature/GenerateInvokeBuild

Conversation

@JustinGrote
Copy link
Copy Markdown
Contributor

@JustinGrote JustinGrote commented Nov 21, 2018

Description

This provides a heavily improved version of the Invoke-Build Psake convert script, and uses it to generate the invoke-build from the psake tasks.

Motivation and Context

Currently IB and psake tasks are manually kept in sync, which may lead to problems if they are not tested together.

How Has This Been Tested?

Pester tests included

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JustinGrote
Copy link
Copy Markdown
Contributor Author

Should be ready for review now, darn Appveyor weirdness...

@devblackops devblackops self-requested a review November 21, 2018 20:03
@devblackops devblackops self-assigned this Nov 21, 2018
@devblackops devblackops added the enhancement New feature or request label Nov 21, 2018
@devblackops
Copy link
Copy Markdown
Member

Thanks @JustinGrote. I'll take a look at this over the weekend.

Copy link
Copy Markdown
Member

@devblackops devblackops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devblackops devblackops merged commit 2ea5bac into psake:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants