Refactor gauss and continuity checks API#351
Merged
JamesMcClung merged 16 commits intopsc-code:mainfrom Apr 16, 2025
Merged
Conversation
this breaks things
Revert this if it's too unclear what's coming from where
germasch
approved these changes
Apr 16, 2025
Contributor
germasch
left a comment
germasch
left a comment
There was a problem hiding this comment.
LGTM -- and nicely structured commits that were easy to follow!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up some checks stuff. The ultimate goal was to (create and) expose
last_max_errin order to use gtest'sEXPECT_*with continuity checks. Relying on theasserts in tests results in unpleasant messages—or worse, nothing at all if it was compiled in release mode, which I usually do...Note that one of these changes breaks compatibility with VPIC checks.