Don't run Docker workflow on push to forks#2324
Merged
JelleZijlstra merged 1 commit intoJun 9, 2021
Merged
Conversation
JelleZijlstra
approved these changes
Jun 9, 2021
ichard26
approved these changes
Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker workflow is used for publishing images to DockerHub which I'm pretty sure people that just try to contribute wouldn't want and the workflow fails because the forks don't have the credentials set up. While it is set to only run on
mainsome people like to keep their fork up-to-date and GitHub even acknowledged that recently making it extremely easy to update from the web.This is also already being done for test.yml workflow so not much reason not to include it here too :)