Get click types from main repo#2344
Conversation
felix-hilden
added
the
ci: skip news
There was a problem hiding this comment.
Kiitos! I think @JelleZijlstra and others might know more about this, but I left a small comment below.
Also, the lint check fails with mypy errors, so perhaps the type hints are slightly different. If this is accepted, should that be addressed in our own code?
| - types-toml >= 0.1.1 | ||
| - types-typed-ast >= 1.4.1 | ||
| - types-click >= 7.1.2 | ||
| - click >= 7.1.2 |
There was a problem hiding this comment.
The linked Click issue was milestoned to version 8. Should this dependency be upgraded then?
Olepas hyvä!
You're right, the annotations are not present in pre v8 click distributions. I changed the requirement to v8 for type annotations.
Fixed now. This was just a drive-by PR made in web browser. I had fingers crossed everything will work with no other changes added, haha. |
|
We still require |
ichard26
left a comment
ichard26
left a comment
There was a problem hiding this comment.
ship it, thanks for the pr!
4 participants
Click types have been moved to click repo itself. See pallets/click#1856
I've had some issues with typeshed types being outdated in another project so might be good to avoid that here.