Skip to content

Fix issue templates + add docs template + PyDis#2399

Merged
ichard26 merged 1 commit into
mainfrom
templates
Jul 28, 2021
Merged

Fix issue templates + add docs template + PyDis#2399
ichard26 merged 1 commit into
mainfrom
templates

Conversation

@ichard26
Copy link
Copy Markdown
Collaborator

The template weren't applying the default labels ever since I renamed
the labels.

There has been enough issues about documentation opened recently so it's
probably worth a template for it.

And oh yeah PyDis exists as a communication method, let's advertise that :)

The template weren't applying the default labels ever since I renamed
the labels.

There has been enough issues about documentation opened recently so it's
probably worth a template for it.
@ichard26 ichard26 added ci: skip news Pull requests that don't need a changelog entry. C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases labels Jul 24, 2021
@JelleZijlstra
Copy link
Copy Markdown
Collaborator

Feel free to merge this whenever you're happy with it.

@ichard26
Copy link
Copy Markdown
Collaborator Author

Yea I assumed that was what implied, I'm in no rush so I'll leave it for a day for any extra feedback (although I doubt there will be any - we'll see).

Copy link
Copy Markdown
Collaborator

@felix-hilden felix-hilden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, disabling empty issues when we have good templates and redirect to a general discussion board would be better in my opinion. But you've probably seen more issues and have more experience than I 😄 and it's an easy change afterwards if we change our mind!

@felix-hilden
Copy link
Copy Markdown
Collaborator

I'm sorry, my comment was too passive. I meant to ask: why do you value empty issues still? Have there been some valid issues that don't have a clear category, or would you not like to e.g. force redirect users to Discord right away?

@ichard26
Copy link
Copy Markdown
Collaborator Author

I like empty issues because they give flexibility to me when I want to open an issue that either 1) doesn't quite fit any of the templates (and is too niche to get one), or 2) I am time limited but still need to get an issue posted so I don't forget. I think the fact it's at the bottom and in smaller text should discourage normal users from creating empty issues unless they really know what they want / are doing :)

@ichard26
Copy link
Copy Markdown
Collaborator Author

It's been a couple of days and there's been no strong feedback so I'mma merge this. We can play with the new fancy issue forms later :)

@ichard26 ichard26 merged commit 4760b6e into main Jul 28, 2021
@ichard26 ichard26 deleted the templates branch July 28, 2021 00:38
ichard26 added a commit that referenced this pull request Aug 8, 2021
The template weren't applying the default labels ever since I renamed
the labels.

There has been enough issues about documentation opened recently so it's
probably worth a template for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: maintenance Related to project maintenance, e.g. CI, testing, policy changes, releases ci: skip news Pull requests that don't need a changelog entry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants