Skip to content

Add --colour/--no-colour alias to --color/--no-color#2803

Closed
Shivansh-007 wants to merge 1 commit into
psf:mainfrom
Shivansh-007:colour-option-alias
Closed

Add --colour/--no-colour alias to --color/--no-color#2803
Shivansh-007 wants to merge 1 commit into
psf:mainfrom
Shivansh-007:colour-option-alias

Conversation

@Shivansh-007
Copy link
Copy Markdown
Contributor

color is the preferred spelling in American English while in British English, colour is preferred. A lot of people use colour (me being one of them) and there is no reason to not support --colour and make them use --color.

@github-actions
Copy link
Copy Markdown
Contributor

diff-shades reports zero changes comparing this PR (7d0bd72) to main (3905173).


What is this? | Workflow run | diff-shades documentation

@isidentical
Copy link
Copy Markdown
Collaborator

Are there any other console tools which alias them together? (just looked a up a few, like pytest which also has --color but no --colour, or pylint which has colorized but not colourized).

Copy link
Copy Markdown
Collaborator

@felix-hilden felix-hilden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is nice, but I'd like it even more if the aliases would be hidden because it will reduce some clutter and still helps with the typo to silently accept both. But I'm not strong on that. Also not strong on including this if other maintainers disagree, but I think it's a nice touch.

Jason's screen shot from the new help:

help

@Shivansh-007
Copy link
Copy Markdown
Contributor Author

Are there any other console tools which alias them together? (just looked a up a few, like pytest which also has --color but no --colour, or pylint which has colorized but not colourized).

Not any that I know of.

@JelleZijlstra
Copy link
Copy Markdown
Collaborator

I'd rather not do this. It complicates the CLI and it's not like "color" won't be understood by people who prefer the British spelling.

@Shivansh-007 Shivansh-007 deleted the colour-option-alias branch January 24, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants