Consolidate test and release workflows + add concurrency limit to test + fuzz#3017
Closed
ichard26 wants to merge 2 commits into
Closed
Consolidate test and release workflows + add concurrency limit to test + fuzz#3017ichard26 wants to merge 2 commits into
ichard26 wants to merge 2 commits into
Conversation
This makes changes across workflow domains easier and overall improves consistency.
ichard26
added
ci: skip news
cooperlees
reviewed
Apr 16, 2022
Collaborator
cooperlees
left a comment
cooperlees
left a comment
There was a problem hiding this comment.
LGTM - How do we test this tho?
Want to update bandersnatch to this cause I do have a release I need to do, would rather screw up a bandersnatch release than black :D
|
|
||
| It will then use [twine](https://pypi.org/project/twine/) to upload both release formats | ||
| to PyPI for general downloading of the _Black_ Python package. This is where | ||
| PyPI is where almost all users will get _Black_ from as it is where where |
Collaborator
There was a problem hiding this comment.
Suggested change
| PyPI is where almost all users will get _Black_ from as it is where where | |
| PyPI is where almost all users will get _Black_ from as it is where |
Collaborator
|
Unfortunately this has a lot of conflicts now, @ichard26 are you able to get back to it? |
Collaborator
If not, please just say so and I'll try find time to do this + other release / CI related things in the coming weeks. |
This was referenced Jul 27, 2022
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes changes across workflow domains easier (like adding concurrency limits) and overall improves consistency. I plan to submit another PR integrating the mypyc workflow from ichard26/black-mypyc-wheels after this is merged. Here's an example run: https://github.com/ichard26/black/actions/runs/2144614522 (including the mypyc patch)
This is probably best landed with a rebase merge fyi.
Checklist - did you ...