Strip pointless f-string#3082
Closed
KAction wants to merge 1 commit into
Closed
Conversation
Author
|
Oh, clearly I based on old revision of master. Not really relevant at this point. |
Collaborator
|
Thanks for your PR @KAction! Are you still interested in improving this? Per our stability policy, the feature should initially be enabled only in |
ichard26
added
S: awaiting response
Author
|
Sorry, I feel this change is bigger and requires more resources than I have right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As promised, I came with patch that mostly does what is discussed in #3081.
Code quality is back-of-envelope, and not all tests are converted. I will fix
it once we decide what to do with the most major issue:
I can't argue that it is very good and valuable sanity check, and just turning
it off seems reckless. Ideas?