Visually standardise badges#3152
Closed
Conversation
ichard26
added
T: documentation
cooperlees
reviewed
Jul 3, 2022
Collaborator
cooperlees
left a comment
cooperlees
left a comment
There was a problem hiding this comment.
Thanks. I kind of prefer us to use GitHub's official badge. I have more faith in their ability to query their infra's runs more efficiently than a 3rd party. I won't block, but wonder what other maintainers think.
Collaborator
|
I agree, also this is IMO a bit pointless so there's no good reason to clutter up the file history. Thanks for the PR and the time you put into it, but I vote to reject this PR. |
Author
|
Thanks for the feedback about the PR. I'm closing it, given the reasons presented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Actions Status badge (the one that displays Test: passing / Test: failing) had a different left side color from all the other badges. With this commit, a badge from the shields.io website is used, standardising the badge styles.
Comparing the change:
Checklist - did you ...
This is a small visual change on the README, so no further work is needed.