Skip to content

Comments

Documented black-jupyter hook#3650

Merged
JelleZijlstra merged 6 commits intopsf:mainfrom
jamesbraza:3641/black-jupyter-docs
Apr 19, 2023
Merged

Documented black-jupyter hook#3650
JelleZijlstra merged 6 commits intopsf:mainfrom
jamesbraza:3641/black-jupyter-docs

Conversation

@jamesbraza
Copy link
Contributor

Description

Closes #3641.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

I locally built the docs and saw it looked fine.

@jamesbraza
Copy link
Contributor Author

Cc @MarcoGorelli

@jamesbraza
Copy link
Contributor Author

jamesbraza commented Apr 17, 2023

If a maintainer could please add the skip news label to this PR, as I think this PR is not worth being in the news

@JelleZijlstra JelleZijlstra added the skip news Pull requests that don't need a changelog entry. label Apr 17, 2023
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! @MarcoGorelli any feedback?

@ichard26 ichard26 added T: documentation Improvements to the docs (e.g. new topic, correction, etc) C: integrations Editor plugins and other integrations labels Apr 18, 2023
@jamesbraza jamesbraza requested a review from ichard26 April 18, 2023 03:25
Copy link
Contributor

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@JelleZijlstra JelleZijlstra merged commit 4b76a54 into psf:main Apr 19, 2023
@jamesbraza jamesbraza deleted the 3641/black-jupyter-docs branch April 19, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: integrations Editor plugins and other integrations skip news Pull requests that don't need a changelog entry. T: documentation Improvements to the docs (e.g. new topic, correction, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documenting black-jupyter pre-commit hook

4 participants