Merged
Conversation
34dcb4a to
d5f8b53
Compare
Contributor
Author
|
Removed the changes.md entry as per reviewer's request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Just doing some cleanup. Removed four internal items that are defined but never referenced anywhere in the codebase:
matches_grammar()inparsing.py—> utility function with zero callerslib2to3_unparse()inparsing.py—> utility function with zero callersis_function_or_class()innodes.py—> function with zero callers (note:is_parent_function_or_classnearby is stillused)
Deprecatedinmode.py— warning class never raised or referencedVerified with grep across all file types — each appears only at its definition.
Found during static analysis with Skylos.
Checklist
--previewstyle?CHANGES.mdif necessary?