Open
Conversation
The parse_line_ranges function previously accepted invalid ranges like '5-3' (start > end) or '0-5' (non-positive line numbers) without raising an error. This adds proper validation with clear error messages.
Collaborator
|
Thanks @avasis-ai! Please add a changelog entry and add types to the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
parse_line_rangesfunction previously accepted invalid ranges without raising errors:"5-3"where START > END"0-5"or"-1-5"with non-positive line numbersThis adds validation to raise a clear
ValueErrorwith a descriptive message when invalid ranges are provided, instead of silently accepting them and producing unexpected formatting behavior.Test Plan
Added
test_parse_line_ranges_validandtest_parse_line_ranges_invalidparametrized tests intests/test_ranges.pycovering: